Repository navigation
unified: Enhance toString of members - #22795
Merged
Merged
Conversation
asgerf
force-pushed
the
unified/member-tostring
branch
from
October 9, 2026 12:15
54321f1 to
154f990
Compare
asgerf
marked this pull request as ready for review
October 9, 2026 12:31
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Members declared in extensions are incorrectly qualified as belonging to an anonymous class.
1 open finding
What changed in this PR
Enhances Unified AST member string representations with qualified and fallback names.
Changes:
- Adds member fallback and qualified-name logic.
- Updates declaration
toString()methods. - Regenerates affected Swift test expectations.
| File | Description |
|---|---|
FacadeAst.qll |
Implements qualified member display names. |
AstExtra.qll |
Enables overlay-local behavior. |
basicblock-slices.expected |
Updates control-flow expectations. |
constructors/test.expected |
Updates constructor expectations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+199
to
+201
| exists(ClassLikeDeclaration cls | | ||
| this = cls.getAMember() and | ||
| result = cls.getQualifiedName() + "." + this.getNameOrFallback() |
hvitved
previously approved these changes
Oct 9, 2026
Includes qualified names and fallback names for anonymous members
asgerf
force-pushed
the
unified/member-tostring
branch
from
October 12, 2026 08:16
8c9c9e1 to
f66896b
Compare
aschackmull
approved these changes
Oct 12, 2026
aschackmull
left a comment
aschackmull
left a comment
Contributor
There was a problem hiding this comment.
Looks like a great improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes qualified names and fallback names for anonymous members